feat(core/managed): limit artifact versions to 30 #8623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmunson
commented
Oct 5, 2020
| @@ -36,7 +36,7 @@ export const getResourceKindForLoadBalancerType = (type: string) => { | |||
| const transformManagedResourceDiff = (diff: IManagedResourceEventHistoryResponse[0]['delta']): IManagedResourceDiff => | |||
| Object.keys(diff).reduce((transformed, key) => { | |||
| const diffNode = diff[key]; | |||
| const fieldKeys = flatMap<string, string>(key.split('/').filter(Boolean), fieldKey => { | |||
| const fieldKeys = flatMap<string, string>(key.split('/').filter(Boolean), (fieldKey) => { | |||
There was a problem hiding this comment.
prettier blew up this file cause it hasn't been touched in a while 🤦
erikmunson
pushed a commit
that referenced
this pull request
Oct 5, 2020
80858e7 feat(core/managed): limit artifact versions to 30 (#8623) 90a2819 feat(core/managed): put constraints in a 'skipped' state on skipped versions (#8620) 815742d feat(core/managed): scroll to selected version in sidebar, update scroll containers (#8618) de24ef3 feat(core/managed): apply consistent sorting to resources (#8622) 3735483 fix(core/pipeline): Always enable "show revision history" in edit pipeline dialog (#8621) abffd84 fix(core/managed): fixup some details from new layout (#8619) f1bb04e fix(appname): encodeURIComponent for app name (#8586) 60c0c7b feat(validation): Allow app name validators to be overridden (#8584)
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2020
…e@0.0.516 docker@0.0.60 google@0.0.21 oracle@0.0.9 tencentcloud@0.0.6 (#8624) * chore(amazon): publish amazon@0.0.269 f1bb04e fix(appname): encodeURIComponent for app name (#8586) * chore(azure): publish azure@0.0.255 f1bb04e fix(appname): encodeURIComponent for app name (#8586) * chore(cloudfoundry): publish cloudfoundry@0.0.101 f1bb04e fix(appname): encodeURIComponent for app name (#8586) * chore(core): publish core@0.0.516 80858e7 feat(core/managed): limit artifact versions to 30 (#8623) 90a2819 feat(core/managed): put constraints in a 'skipped' state on skipped versions (#8620) 815742d feat(core/managed): scroll to selected version in sidebar, update scroll containers (#8618) de24ef3 feat(core/managed): apply consistent sorting to resources (#8622) 3735483 fix(core/pipeline): Always enable "show revision history" in edit pipeline dialog (#8621) abffd84 fix(core/managed): fixup some details from new layout (#8619) f1bb04e fix(appname): encodeURIComponent for app name (#8586) 60c0c7b feat(validation): Allow app name validators to be overridden (#8584) * chore(docker): publish docker@0.0.60 f1bb04e fix(appname): encodeURIComponent for app name (#8586) * chore(google): publish google@0.0.21 f1bb04e fix(appname): encodeURIComponent for app name (#8586) * chore(oracle): publish oracle@0.0.9 f1bb04e fix(appname): encodeURIComponent for app name (#8586) * chore(tencentcloud): publish tencentcloud@0.0.6 f1bb04e fix(appname): encodeURIComponent for app name (#8586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of trying to do some short-term tweaks to improve Environments performance, this change caps the maximum number of artifact versions we fetch to 30. Above 30 I begin to see increased variability in latency that I'm not super comfortable with (i.e. getting >3s latency on a percentage of calls).