Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(targetShape): remove the ALPHA conditional on the targetShape #8787

Merged
merged 2 commits into from
Dec 11, 2020
Merged

feat(targetShape): remove the ALPHA conditional on the targetShape #8787

merged 2 commits into from
Dec 11, 2020

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Dec 11, 2020

This feature has now launched to GA.

See #8089

maggieneterval
maggieneterval approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 🅰️ 🎯 🟥 ✅ 💯

@plumpy plumpy added the ready to merge Reviewed and ready for merge label Dec 11, 2020
@mergify mergify bot merged commit 1446fac into spinnaker:master Dec 11, 2020
erikmunson pushed a commit that referenced this pull request Dec 11, 2020
chore(google): publish google@0.0.29
16eb247 
1446fac feat(targetShape): remove the ALPHA conditional on the targetShape (#8787)
@erikmunson erikmunson mentioned this pull request Dec 11, 2020
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2020
@mergify
chore(google): publish google@0.0.29
487c939 
1446fac feat(targetShape): remove the ALPHA conditional on the targetShape (#8787)
@plumpy plumpy deleted the targetShape branch December 11, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggieneterval maggieneterval maggieneterval approved these changes

Assignees
No one assigned
Labels
ready to merge Reviewed and ready for merge target-release/1.25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plumpy @maggieneterval @spinnakerbot