feat(aws): Add scheme to load balancer details #8797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
approved these changes
Dec 15, 2020
|
There is no "titus load balancer" and I was never here. 😄 |
christopherthielen
added a commit
that referenced
this pull request
Dec 16, 2020
1d4320a refactor(REST): Prefer REST('/foo/bar') over REST().path('foo', 'bar') 97bfbf6 refactor(api-deprecation): API is deprecated, switch to REST() 39b08e7 refactor(api-deprecation): Prefer API.path('foo', 'bar') over API.path('foo').path('bar') 587db3a refactor(api-deprecation): Migrate from API.one/all/withParams/getList() to path/query/get() 807de9a test(mock-http-client): Remove unnecessary API.baseUrl prefix in expectGET/etc calls 924e80b test(mock-http-client): Remove no longer needed references to $httpBackend in unit tests after migration to MockHttpClient e123818 test(mock-http-client): Manually fix tests which didn't pass after auto-migrating using the eslint rule migrate-to-mock-http-client --fix ef5d8ea test(mock-http-client): Run eslint rule migrate-to-mock-http-client --fix 4f13518 feat(aws): Add scheme to load balancer details (#8797) 969f4fe Avoid raw "$http" usage (#8790) 40ba12c fix(aws): Misc. fixes and new unit tests (#8742)
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2020
1d4320a refactor(REST): Prefer REST('/foo/bar') over REST().path('foo', 'bar') 97bfbf6 refactor(api-deprecation): API is deprecated, switch to REST() 39b08e7 refactor(api-deprecation): Prefer API.path('foo', 'bar') over API.path('foo').path('bar') 587db3a refactor(api-deprecation): Migrate from API.one/all/withParams/getList() to path/query/get() 807de9a test(mock-http-client): Remove unnecessary API.baseUrl prefix in expectGET/etc calls 924e80b test(mock-http-client): Remove no longer needed references to $httpBackend in unit tests after migration to MockHttpClient e123818 test(mock-http-client): Manually fix tests which didn't pass after auto-migrating using the eslint rule migrate-to-mock-http-client --fix ef5d8ea test(mock-http-client): Run eslint rule migrate-to-mock-http-client --fix 4f13518 feat(aws): Add scheme to load balancer details (#8797) 969f4fe Avoid raw "$http" usage (#8790) 40ba12c fix(aws): Misc. fixes and new unit tests (#8742)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just exposing a load balancer's scheme in the details pane:
(options are
internalorinternet-facing)