fix(core/cluster): Clicking an instance breaks rendering of cluster pods #8866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyhebebrand
requested review from
alanmquach,
christopherthielen and
vigneshm
christopherthielen
added a commit
that referenced
this pull request
Feb 3, 2021
274944f feat(md): Collasible metadata elements (#8880) c7a58cd fix(core/cluster): Clicking an instance breaks rendering of cluster pods (#8866) 76cd8cd feat(core): Add a new variable that is interpolated in instance links (#8868) b3ae753 fix(core): add vertical padding on page owner nav link (#8876) 7d94b69 feat(core): Expose raw subnet ID (#8877)
mergify bot
pushed a commit
that referenced
this pull request
Feb 3, 2021
274944f feat(md): Collasible metadata elements (#8880) c7a58cd fix(core/cluster): Clicking an instance breaks rendering of cluster pods (#8866) 76cd8cd feat(core): Add a new variable that is interpolated in instance links (#8868) b3ae753 fix(core): add vertical padding on page owner nav link (#8876) 7d94b69 feat(core): Expose raw subnet ID (#8877)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AutoSizerwas only listening to a window resize, but when an instance or server group is selected, rows also need to be resized. This caused the server group views to render on top of each other once the details panel was opened.This PR adds a subscription to listen for opening/closing the details panel so that the cluster pods can re-render with appropriate heights.