Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): Cannot see instance details for ecs cluster #9157

Merged
merged 2 commits into from
May 27, 2021
Merged

fix(ecs): Cannot see instance details for ecs cluster #9157

merged 2 commits into from
May 27, 2021

Conversation

paragbhingre
Copy link
Contributor

@paragbhingre paragbhingre commented May 12, 2021 •
edited
Loading

This PR fixes the #6405

In 1.25 release, De-angularize InstanceWriter PR got released which broke the existing functionality of the InstanceWriter in ecs module as changes related to ecs got skipped in that particular release. We have fixed the InstanceWriter dependency issue in this PR.

Screen Shot 2021-05-27 at 10 32 44 AM

@allisaurus allisaurus self-assigned this May 18, 2021
allisaurus
allisaurus requested changes May 19, 2021
View reviewed changes
Copy link
Contributor

@allisaurus allisaurus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes for using the new InstanceWriter LGTM, I mostly have feedback about the test
(which I'm very happy to see you've added, btw!)

test/functional/cypress/integration/ecs/clusters_list.spec.js Outdated Show resolved Hide resolved
test/functional/cypress/integration/ecs/clusters_list.spec.js Show resolved Hide resolved
test/functional/cypress/integration/ecs/clusters_list.spec.js Outdated Show resolved Hide resolved
test/functional/cypress/integration/ecs/clusters_list.spec.js Outdated Show resolved Hide resolved
allisaurus
allisaurus approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@allisaurus allisaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@allisaurus allisaurus added the ready to merge Reviewed and ready for merge label May 27, 2021
@mergify mergify bot merged commit c20da7a into spinnaker:master May 27, 2021
@allisaurus
Copy link
Contributor

@link108 per spinnaker/spinnaker#6406 it looks like this is a regression present in 1.25 and 1.26. Would we be able to backport this to the next patch releases of these versions?

@link108
Copy link
Member

link108 commented May 27, 2021

@allisaurus Yup, will create backports for these now and create another patch next week

@link108
Copy link
Member

link108 commented May 27, 2021

@Mergifyio backport release-1.25.x release-1.26.x

mergify bot pushed a commit that referenced this pull request May 27, 2021
@paragbhingre
fix(ecs): Cannot see instance details for ecs cluster (#9157)
23eff93 
(cherry picked from commit c20da7a)
@mergify mergify bot mentioned this pull request May 27, 2021
Merged
mergify bot pushed a commit that referenced this pull request May 27, 2021
@paragbhingre
fix(ecs): Cannot see instance details for ecs cluster (#9157)
1a5c9a9 
(cherry picked from commit c20da7a)
@mergify mergify bot mentioned this pull request May 27, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented May 27, 2021

Command backport release-1.25.x release-1.26.x: success

Backports have been created

@allisaurus allisaurus added backport-candidate Add to PRs to designate release branch patch candidates. and removed backport-candidate Add to PRs to designate release branch patch candidates. labels May 28, 2021
ranihorev pushed a commit that referenced this pull request Jun 1, 2021
chore(ecs): publish ecs@0.0.287
f5ac1b4 
c20da7a fix(ecs): Cannot see instance details for ecs cluster (#9157)
@ranihorev ranihorev mentioned this pull request Jun 1, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jun 1, 2021
@mergify
chore(ecs): publish ecs@0.0.287
9d3013a 
c20da7a fix(ecs): Cannot see instance details for ecs cluster (#9157)
mergify bot added a commit that referenced this pull request Jun 14, 2021
@mergify @paragbhingre @link108
fix(ecs): Cannot see instance details for ecs cluster (#9157) (#9257)
ef229a1 
(cherry picked from commit c20da7a)

Co-authored-by: Parag Sanjay Bhingre <pbhingre@amazon.com>
Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com>
mergify bot added a commit that referenced this pull request Jun 14, 2021
@mergify @paragbhingre @link108
fix(ecs): Cannot see instance details for ecs cluster (#9157) (#9256)
803c512 
(cherry picked from commit c20da7a)

Co-authored-by: Parag Sanjay Bhingre <pbhingre@amazon.com>
Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisaurus allisaurus allisaurus approved these changes

Assignees

@allisaurus allisaurus

Labels
ready to merge Reviewed and ready for merge target-release/1.27
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paragbhingre @allisaurus @link108 @spinnakerbot