Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(md): MD debug mode #9401

Merged
merged 3 commits into from
Jul 7, 2021
Merged

feat(md): MD debug mode #9401

merged 3 commits into from
Jul 7, 2021

Conversation

ranihorev
Copy link
Contributor

There is some functionality that we don't want to expose to users by default, but could be useful for us for debugging. This PR includes:

  • Store to the debug mode to localStorage by setting md_enabled as enabled and drop it by setting it to disabled
  • Show the processed delivery config when enabled
  • Show "Copy artifact version" when enabled
  • More to come

Copy link
Contributor

@caseyhebebrand caseyhebebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lorin lorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this!

@ranihorev ranihorev added the ready to merge Reviewed and ready for merge label Jul 7, 2021
@mergify mergify bot merged commit 09c275d into spinnaker:master Jul 7, 2021
ranihorev pushed a commit that referenced this pull request Jul 8, 2021
19f97af chore(refactor): Convert NumberList to react (#9389)
fa8bf20 feat(managed-delivery): Add resource deleting status and icon (#9413)
cce5473 chore(*): Import TaskMonitorWrapper from core instead of NgReact (#9406)
5dc1dea refactor(fonts): Move fonts to core
15dc938 fix(tasks): Handle tasks with no stages (#9403)
09c275d feat(md): MD debug mode (#9401)
mergify bot pushed a commit that referenced this pull request Jul 8, 2021
19f97af chore(refactor): Convert NumberList to react (#9389)
fa8bf20 feat(managed-delivery): Add resource deleting status and icon (#9413)
cce5473 chore(*): Import TaskMonitorWrapper from core instead of NgReact (#9406)
5dc1dea refactor(fonts): Move fonts to core
15dc938 fix(tasks): Handle tasks with no stages (#9403)
09c275d feat(md): MD debug mode (#9401)
@ranihorev ranihorev deleted the md/debug-mode branch July 13, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Reviewed and ready for merge target-release/1.27
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants