Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump select2 to npm versions #9763

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

mattgogerly
Copy link
Member

Bumping select2 dependencies to versions that are in NPM. I couldn't get an answer on why these are currently fixed at Git tags, so please let me know if you know why.

@mattgogerly
Copy link
Member Author

mattgogerly commented Nov 2, 2021

cc @christopherthielen @dogonthehorizon @caseyhebebrand mind reviewing this? These dependencies are causing us issues in procurement and I can't find anybody who knows why they're pinned.

@christopherthielen
Copy link
Contributor

christopherthielen commented Nov 3, 2021

I also couldn't find a reason these were pinned. I don't think we're even including select2 in deck except for CSS.

Seems fairly safe to merge this IMO

@christopherthielen christopherthielen merged commit deee318 into spinnaker:master Nov 3, 2021
@mattgogerly mattgogerly deleted the patch-1 branch November 4, 2021 16:02
@mattgogerly
Copy link
Member Author

@Mergifyio backport release-1.27.x

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2022

backport release-1.27.x

✅ Backports have been created

dbyron-sf pushed a commit that referenced this pull request Mar 22, 2022
* chore(deps): use select2 version from NPM

(cherry picked from commit deee318)

# Conflicts:
#	packages/core/package.json

* chore(deps): bump select2 to npm versions (backport #9763)

* chore(deps): switch to Source Sans 3 package (#9673)

Co-authored-by: mattgogerly <matthewgogerly@gmail.com>
Co-authored-by: Matt <6519811+mattgogerly@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants