Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Upload halconfigs to GCS on Tag push #9838

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

kskewes-sf
Copy link
Contributor

Previous release tools would publish basic halconfig profiles to GCS
bucket: https://console.cloud.google.com/storage/browser/halconfig/<service>/<version>/*

Where <service> might be rosco and <version> is our git tag, eg: v1.2.3.

Halyard downloads these profiles during hal deploy apply.
As the profiles are deprecated it would be ideal to remove from Halyard
but it may break users workflows.

For now we can upload the files as part of our regular service 'release'
flow (git tag && git push) using GHA.

Previous release tools would publish basic halconfig profiles to GCS
bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*)

Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`.

Halyard downloads these profiles during `hal deploy apply`.
As the profiles are deprecated it would be ideal to remove from Halyard
but it may break users workflows.

For now we can upload the files as part of our regular service 'release'
flow (git tag <version> && git push) using GHA.
@dbyron-sf dbyron-sf added the ready to merge Reviewed and ready for merge label Apr 20, 2022
@mergify mergify bot added the auto merged Merged automatically by a bot label Apr 20, 2022
@mergify mergify bot merged commit f134927 into spinnaker:master Apr 20, 2022
@dbyron-sf
Copy link
Contributor

@Mergifyio backport release-1.27.x release-1.28.x

mergify bot pushed a commit that referenced this pull request Apr 26, 2022
Previous release tools would publish basic halconfig profiles to GCS
bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*)

Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`.

Halyard downloads these profiles during `hal deploy apply`.
As the profiles are deprecated it would be ideal to remove from Halyard
but it may break users workflows.

For now we can upload the files as part of our regular service 'release'
flow (git tag <version> && git push) using GHA.

(cherry picked from commit f134927)
mergify bot pushed a commit that referenced this pull request Apr 26, 2022
Previous release tools would publish basic halconfig profiles to GCS
bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*)

Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`.

Halyard downloads these profiles during `hal deploy apply`.
As the profiles are deprecated it would be ideal to remove from Halyard
but it may break users workflows.

For now we can upload the files as part of our regular service 'release'
flow (git tag <version> && git push) using GHA.

(cherry picked from commit f134927)
@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

backport release-1.27.x release-1.28.x

✅ Backports have been created

mergify bot added a commit that referenced this pull request Apr 26, 2022
Previous release tools would publish basic halconfig profiles to GCS
bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*)

Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`.

Halyard downloads these profiles during `hal deploy apply`.
As the profiles are deprecated it would be ideal to remove from Halyard
but it may break users workflows.

For now we can upload the files as part of our regular service 'release'
flow (git tag <version> && git push) using GHA.

(cherry picked from commit f134927)

Co-authored-by: kskewes-sf <96093759+kskewes-sf@users.noreply.github.com>
link108 added a commit that referenced this pull request Jul 14, 2022
Co-authored-by: kskewes-sf <96093759+kskewes-sf@users.noreply.github.com>
Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants