Skip to content

Commit

Permalink
fix(plugins-test): try harder for the version of versionNotSupportedP…
Browse files Browse the repository at this point in the history
…lugin to actually not be supported (#1161) (#1165)

Before this, an echo version >= 2.0.0 would cause versionNotSupportedPlugin to get used,
causing tests to fail, and making it impossible to e.g. release echo.

(cherry picked from commit 24774bd)

Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
  • Loading branch information
mergify[bot] and dbyron-sf committed Mar 21, 2022
1 parent 9fc5d56 commit b03c87e
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ class EchoPluginsFixture : PluginsTckFixture, EchoTestService() {
plugins.mkdir()
enabledPlugin = buildPlugin("com.netflix.echo.enabled.plugin", ">=1.0.0")
disabledPlugin = buildPlugin("com.netflix.echo.disabled.plugin", ">=1.0.0")
versionNotSupportedPlugin = buildPlugin("com.netflix.echo.version.not.supported.plugin", ">=2.0.0")
// Make it very unlikely that the version of echo satisfies this requirement
versionNotSupportedPlugin = buildPlugin("com.netflix.echo.version.not.supported.plugin", "=0.0.9")
}
}

Expand Down

0 comments on commit b03c87e

Please sign in to comment.