Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins-test): try harder for the version of versionNotSupportedP… (backport #1161) #1165

Merged
merged 1 commit into from
Mar 21, 2022
Merged

fix(plugins-test): try harder for the version of versionNotSupportedP… (backport #1161) #1165

merged 1 commit into from
Mar 21, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 21, 2022

This is an automatic backport of pull request #1161 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@dbyron-sf
fix(plugins-test): try harder for the version of versionNotSupportedP…
5e21e44 
…lugin to actually not be supported (#1161)

Before this, an echo version >= 2.0.0 would cause versionNotSupportedPlugin to get used,
causing tests to fail, and making it impossible to e.g. release echo.

(cherry picked from commit 24774bd)
@mergify mergify bot mentioned this pull request Mar 21, 2022
Merged
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Mar 21, 2022
@mergify mergify bot added the auto merged label Mar 21, 2022
@mergify mergify bot merged commit b03c87e into release-1.27.x Mar 21, 2022
@mergify mergify bot deleted the mergify/bp/release-1.27.x/pr-1161 branch March 21, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.27
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbyron-sf @spinnakerbot