Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins-test): try harder for the version of versionNotSupportedP… #1161

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

dbyron-sf
Copy link
Contributor

…lugin to actually not be supported

Before this, an echo version >= 2.0.0 would cause versionNotSupportedPlugin to get used,
causing tests to fail, and making it impossible to e.g. release echo.

…lugin to actually not be supported

Before this, an echo version >= 2.0.0 would cause versionNotSupportedPlugin to get used,
causing tests to fail, and making it impossible to e.g. release echo.
Copy link
Contributor

@kskewes-sf kskewes-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tags are well up above 2 now.

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Mar 14, 2022
@mergify mergify bot added the auto merged label Mar 14, 2022
@dbyron-sf dbyron-sf merged commit 24774bd into spinnaker:master Mar 14, 2022
@dbyron-sf dbyron-sf deleted the fix-plugins-version branch March 14, 2022 22:21
@kskewes-sf
Copy link
Contributor

Please:

@Mergifyio backport release-1.27.x

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2022

@kskewes-sf is not allowed to run commands

@dbyron-sf
Copy link
Contributor Author

@Mergifyio backport release-1.27.x

mergify bot pushed a commit that referenced this pull request Mar 21, 2022
…lugin to actually not be supported (#1161)

Before this, an echo version >= 2.0.0 would cause versionNotSupportedPlugin to get used,
causing tests to fail, and making it impossible to e.g. release echo.

(cherry picked from commit 24774bd)
@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2022

backport release-1.27.x

✅ Backports have been created

mergify bot added a commit that referenced this pull request Mar 21, 2022
…lugin to actually not be supported (#1161) (#1165)

Before this, an echo version >= 2.0.0 would cause versionNotSupportedPlugin to get used,
causing tests to fail, and making it impossible to e.g. release echo.

(cherry picked from commit 24774bd)

Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants