feat(jira): Add Jira issue transition to JiraNotificationService #1080
Conversation
|
|
||
| @Component | ||
| @ConditionalOnProperty("jira.enabled") | ||
| public class JiraNotificationService implements NotificationService { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(JiraNotificationService.class); | ||
| private static final int MAX_RETRY = 3; | ||
| private static final long RETRY_BACKOFF = 3; | ||
| private static final long RETRY_BACKOFF = 100; |
There was a problem hiding this comment.
A retry backoff of 3ms seemed absurdly low, setting this to 100ms.
There was a problem hiding this comment.
No strong opinions, just don't follow the point of sleeping for 3 milliseconds (my reasoning is it may as well be zero in that case). 🤷♂️
There was a problem hiding this comment.
My original comment was a joke, sorry ... I suspect the original was a big mistake.
Honestly, because it's a linear backoff and only 3 attempts, I'd probably do a couple seconds or something.
There was a problem hiding this comment.
Hah, I thought maybe you were joking but I totally couldn't tell 😂
jonsie
force-pushed
the
add-jira-transition
branch
from
15165e6
to
d873662
Compare
| kv("transitionRequestBody", transitionContext), errors(e)), | ||
| e); | ||
| } | ||
| } |
There was a problem hiding this comment.
Error on invalid transition name looks like:
Failed to transition Jira issue EXMPL-0000: {errors={issue=EXMPL-0000, transitionName=Done, validTransitionNames=[Reopen, Reopen and start progress]}}
4b9a622
to
8b2f283
Compare
`transitionContext` payload can be the full Jira transition REST API payload, however the transition ID will be looked up based on the transition name
jonsie
force-pushed
the
add-jira-transition
branch
from
8b2f283
to
6e13feb
Compare
|
|
||
| @Component | ||
| @ConditionalOnProperty("jira.enabled") | ||
| public class JiraNotificationService implements NotificationService { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(JiraNotificationService.class); | ||
| private static final int MAX_RETRY = 3; | ||
| private static final long RETRY_BACKOFF = 3; | ||
| private static final long RETRY_BACKOFF = 100; |
echo-notifications/src/main/groovy/com/netflix/spinnaker/echo/jira/JiraNotificationService.java
Outdated
Show resolved
Hide resolved
|
Added option to comment on issue. |
|
New object looks good to me (not sure if there's lombok in here and @DaTa would have been sufficed over get/set ... either way I'm ok). |
transitionContextpayload can be the full Jira transition REST API payload, however the transition ID will be looked up based on the transition name