feat(pubsub): add support for links in pubsub triggers #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Dec 13, 2022
| .atParameters(parameters) | ||
| .atPayload(payload) | ||
| .atEventId(pubsubEvent.getEventId()); | ||
| String linkText = (String) payload.get("linkText"); |
There was a problem hiding this comment.
Is it too paranoid to be worried about payload.get("linkText"); or payload.get("link"); being something besides a string? How about some instanceof checks first?
It is nice how how Jenkins triggers display a link back to the build that triggered the pipeline. This keys off the link and linkText properties in the Trigger object. I would like to see this same behavior supported for pubsub triggers. This change allows senders of pubsub events to add link and linkText in the trigger message payload, and thus set a link that will be displayed in the pipeline execution UI.
chris-h-phillips
force-pushed
the
add_link_to_pubsub
branch
from
22824ad
to
3eb2ce1
Compare
dbyron-sf
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is nice how how Jenkins triggers display a link back to the build that triggered the pipeline. This keys off the link and linkText properties in the Trigger object. I would like to see this same behavior supported for pubsub triggers. This change allows senders of pubsub events to add link and linkText in the trigger message payload, and thus set a link that will be displayed in the pipeline execution UI.
I tested this out on our spinnaker installation and it renders the link like a champ: