-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Upload halconfigs to GCS on Tag push #1120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous release tools would publish basic halconfig profiles to GCS bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*) Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`. Halyard downloads these profiles during `hal deploy apply`. As the profiles are deprecated it would be ideal to remove from Halyard but it may break users workflows. For now we can upload the files as part of our regular service 'release' flow (git tag <version> && git push) using GHA.
dbyron-sf
approved these changes
Apr 20, 2022
@Mergifyio backport release-1.27.x release-1.28.x |
mergify bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Previous release tools would publish basic halconfig profiles to GCS bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*) Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`. Halyard downloads these profiles during `hal deploy apply`. As the profiles are deprecated it would be ideal to remove from Halyard but it may break users workflows. For now we can upload the files as part of our regular service 'release' flow (git tag <version> && git push) using GHA. (cherry picked from commit 60c4ccb)
mergify bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Previous release tools would publish basic halconfig profiles to GCS bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*) Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`. Halyard downloads these profiles during `hal deploy apply`. As the profiles are deprecated it would be ideal to remove from Halyard but it may break users workflows. For now we can upload the files as part of our regular service 'release' flow (git tag <version> && git push) using GHA. (cherry picked from commit 60c4ccb)
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Apr 26, 2022
Previous release tools would publish basic halconfig profiles to GCS bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*) Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`. Halyard downloads these profiles during `hal deploy apply`. As the profiles are deprecated it would be ideal to remove from Halyard but it may break users workflows. For now we can upload the files as part of our regular service 'release' flow (git tag <version> && git push) using GHA. (cherry picked from commit 60c4ccb) Co-authored-by: kskewes-sf <96093759+kskewes-sf@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Apr 26, 2022
Previous release tools would publish basic halconfig profiles to GCS bucket: [https://console.cloud.google.com/storage/browser/halconfig/`<service>`/`<version>`/*](https://console.cloud.google.com/storage/browser/halconfig/%60%3Cservice%3E%60/%60%3Cversion%3E%60/*) Where `<service>` might be `rosco` and `<version>` is our git tag, eg: `v1.2.3`. Halyard downloads these profiles during `hal deploy apply`. As the profiles are deprecated it would be ideal to remove from Halyard but it may break users workflows. For now we can upload the files as part of our regular service 'release' flow (git tag <version> && git push) using GHA. (cherry picked from commit 60c4ccb) Co-authored-by: kskewes-sf <96093759+kskewes-sf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous release tools would publish basic halconfig profiles to GCS
bucket: https://console.cloud.google.com/storage/browser/halconfig/
<service>
/<version>
/*Where
<service>
might berosco
and<version>
is our git tag, eg:v1.2.3
.Halyard downloads these profiles during
hal deploy apply
.As the profiles are deprecated it would be ideal to remove from Halyard
but it may break users workflows.
For now we can upload the files as part of our regular service 'release'
flow (git tag && git push) using GHA.