feat(api): test endpoint that throws an exception #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gal-yardeni
reviewed
Mar 25, 2020
keel-web/src/main/kotlin/com/netflix/spinnaker/keel/rest/TestController.kt
Outdated
Show resolved
Hide resolved
gal-yardeni
reviewed
Mar 25, 2020
keel-web/src/main/kotlin/com/netflix/spinnaker/keel/rest/TestController.kt
Outdated
Show resolved
Hide resolved
luispollo
reviewed
Mar 26, 2020
keel-web/src/main/kotlin/com/netflix/spinnaker/keel/rest/TestController.kt
Outdated
Show resolved
Hide resolved
luispollo
reviewed
Mar 26, 2020
| path = ["/error"], | ||
| produces = [APPLICATION_JSON_VALUE, APPLICATION_YAML_VALUE] | ||
| ) | ||
| fun throwAnException(): String { |
There was a problem hiding this comment.
Would it be useful to support different types of exceptions/status codes? If so, you could add a parameter with the desired status code and throw an exception you know would cause that code to be returned.
There was a problem hiding this comment.
Yeah, I think it's potentially useful to support simulations of different kinds of errors, and I'd like to hold off on adding this functionality until we have tests that are consuming them (this meets my current testing needs for the exception alerts).
|
My test is failing because I have to enable the new |
added 4 commits
March 26, 2020 16:51
Add a /test/error endpoint that throws an exception (returns 500 error) when hit. This is intended to assist in testing error alerts, by giving us a reliable way to induce errors.
gal-yardeni
approved these changes
Mar 27, 2020
luispollo
approved these changes
Mar 27, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
/test/errorendpoint that throws an exception (and, consequently, returns a 500 error) when hit.This is intended to assist in testing error alerts, by giving us a reliable way to induce errors.