Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(appengine): Add tests demonstrating AppEngine artifact bug #3772

Merged
merged 4 commits into from
Jun 24, 2020
Merged

test(appengine): Add tests demonstrating AppEngine artifact bug #3772

merged 4 commits into from
Jun 24, 2020

Commits on Jun 24, 2020

  1. fix(provider/appengine): Temporarily revert fix

    This reverts commit 711c21a. After
    adding tests to demonstrate the bug and fix, we'll re-apply.
    ezimanyi committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    3e6c673 View commit details
    Browse the repository at this point in the history
  2. test(appengine): Add tests demonstrating AppEngine artifact bug

    This commit adds tests to demonstrate the regression in the
    AppEngine artifact handling. The next commit will fix the bug
    and update the tests.
    ezimanyi committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    7c096d0 View commit details
    Browse the repository at this point in the history
  3. fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755)

    groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts  were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact.
    
    Co-Authored-By: Eric Zimanyi <ezimanyi@google.com>
    guido9j and ezimanyi committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    0e39f8b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d1104d8 View commit details
    Browse the repository at this point in the history