fix(traffic guards): avoid server group lookup #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On verifyInstanceTermination, short circuit checks for server group instance state if there are no enabled traffic guards for the server group
| @@ -231,7 +260,8 @@ public void verifyTrafficRemoval( | |||
| TargetServerGroup someServerGroup = serverGroupsGoingAway.stream().findAny().get(); | |||
| Location location = someServerGroup.getLocation(); | |||
|
|
|||
| if (!hasDisableLock(someServerGroup.getMoniker(), account, location)) { | |||
| Front50Cache front50Cache = new Front50Cache(this); | |||
There was a problem hiding this comment.
doesn't creating a new cache here defeat some of the cache benefit vs passing it in from line 248?
There was a problem hiding this comment.
the intent of the cache is it should just live through one public call path through TrafficGuard, so this one is at the start of one of the public verifyTrafficRemoval signatures that eventually calls the same verifyTrafficRemovalInternal as line 248 is calling
There was one case where (for instance termination) the entrypoint from one public method was calling into another public method so that is where I introduced a private method that allows propagating the cache along
marchello2000
approved these changes
Jul 1, 2020
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
On verifyInstanceTermination, short circuit checks for server group instance state if there are no enabled traffic guards for the server group Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On verifyInstanceTermination, short circuit checks for
server group instance state if there are no enabled
traffic guards for the server group