fix(wait): Fix wait for up instances task #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change in clouddriver spinnaker/clouddriver#4681 added a boolean `pinned` field to the `Capacity` object in `ServerGroup`. However there's some code in the `WaitForUpInstancesTask` in Orca that depends on the types all being `Integer`. The end result is that the wait task fails with a stack trace like: ``` org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'true' with class 'java.lang.Boolean' to class 'java.lang.Integer' ``` This patch updates the task to just get the fields it needs to compare and adds a test for this case.
…pinnaker#3945) * test(preconfigured): include integration test for preconfigured job with kubernetes provider * refactor(preconfigured): refactor test
…led (spinnaker#3959) Similar to the bake stage, `skipRegionDetection` can be used to determine whether or not additional regions are inferred from downstream deploy stages. The default value is `false` which preserves the existing behavior. ``` { ... "skipRegionDetection": true } ```
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…x values are different and resolve the difference (spinnaker#3960)
Co-authored-by: root <root@877703f80d77>
robzienert
approved these changes
Oct 28, 2020
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
* fix(wait): Fix wait for up instances task This change in clouddriver spinnaker/clouddriver#4681 added a boolean `pinned` field to the `Capacity` object in `ServerGroup`. However there's some code in the `WaitForUpInstancesTask` in Orca that depends on the types all being `Integer`. The end result is that the wait task fails with a stack trace like: ``` org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'true' with class 'java.lang.Boolean' to class 'java.lang.Integer' ``` This patch updates the task to just get the fields it needs to compare and adds a test for this case. * chore(kork): update kork dependency (now w/ moniker) (spinnaker#3958) * test(preconfigured): include integration test for preconfigured job (spinnaker#3945) * test(preconfigured): include integration test for preconfigured job with kubernetes provider * refactor(preconfigured): refactor test * feat(clouddriver): Look ahead region detection for "aws" can be disabled (spinnaker#3959) Similar to the bake stage, `skipRegionDetection` can be used to determine whether or not additional regions are inferred from downstream deploy stages. The default value is `false` which preserves the existing behavior. ``` { ... "skipRegionDetection": true } ``` * feat(orca): Add support for Redis SSL (spinnaker#3934) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * feat(queue): Add command to cleanup zombie executions (spinnaker#3946) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * fix(bake): Log when bake request amiSuffix and stage context amiSuffix values are different and resolve the difference (spinnaker#3960) * chore(dependencies): Autobump spinnakerGradleVersion (spinnaker#3962) Co-authored-by: root <root@877703f80d77> Co-authored-by: Michael Plump <plumpy@google.com> Co-authored-by: Edgar Garcia <63310723+edgarulg@users.noreply.github.com> Co-authored-by: Adam Jordens <adam@jordens.org> Co-authored-by: tompiscitell <tompiscitell@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Rob Zienert <rzienert@netflix.com> Co-authored-by: Chris Smalley <csmalley@netflix.com> Co-authored-by: spinnakerbot <spinbot@spinnaker.io> Co-authored-by: root <root@877703f80d77>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in clouddriver spinnaker/clouddriver#4681 added a boolean
pinnedfield to theCapacityobject inServerGroup. However there's some code in theWaitForUpInstancesTaskin Orca that depends on the types all beingInteger. The end result is that the wait task fails with a stack trace like:This patch updates the task to just get the fields it needs to compare and adds a test for this case.