fix(bake): Improve error message #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When supplying an artifact without a reference, we currently throw an NPE that is hard to debug. Replace this with a better error message. (At some point we could consider if we even need a reference at all, or if we could fall back to something else, but for now this will at least make the restriction clearer.)
ethanfrogers
approved these changes
May 18, 2019
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 15, 2020
When supplying an artifact without a reference, we currently throw an NPE that is hard to debug. Replace this with a better error message. (At some point we could consider if we even need a reference at all, or if we could fall back to something else, but for now this will at least make the restriction clearer.)
opsmxdemo
pushed a commit
to OpsMx/rosco
that referenced
this pull request
Sep 16, 2020
When supplying an artifact without a reference, we currently throw an NPE that is hard to debug. Replace this with a better error message. (At some point we could consider if we even need a reference at all, or if we could fall back to something else, but for now this will at least make the restriction clearer.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#4110
When supplying an artifact without a reference, we currently throw an NPE that is hard to debug. Replace this with a better error message.
(At some point we could consider if we even need a reference at all, or if we could fall back to something else, but for now this will at least make the restriction clearer.)