Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rosco-bom): publish rosco-bom #556

Merged
merged 1 commit into from
Mar 10, 2020
Merged

feat(rosco-bom): publish rosco-bom #556

merged 1 commit into from
Mar 10, 2020

Conversation

fieldju
Copy link
Contributor

@fieldju fieldju commented Mar 10, 2020

This simplifies dependency resolution downstream and is modeled off of -> spinnaker/clouddriver#3794

cfieber
cfieber approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@cfieber cfieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@fieldju fieldju merged commit 7f570d4 into spinnaker:master Mar 10, 2020
@fieldju
Copy link
Contributor Author

fieldju commented Mar 10, 2020

@spinnakerbot cherry-pick 1.18

@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit 7f570d4) with exit code 1:

error: could not apply 7f570d4... feat(rosco-bom): publish rosco-bom (#556)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

opsmxdemo pushed a commit to OpsMx/rosco that referenced this pull request Sep 15, 2020
@fieldju @opsmxyuga22
feat(rosco-bom): publish rosco-bom (spinnaker#556)
8ff0ccd
opsmxdemo pushed a commit to OpsMx/rosco that referenced this pull request Sep 16, 2020
@fieldju @opsmxyuga22
feat(rosco-bom): publish rosco-bom (spinnaker#556)
4c514cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfieber cfieber cfieber approved these changes

@marchello2000 marchello2000 Awaiting requested review from marchello2000

Assignees
No one assigned
Labels
target-release/1.20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fieldju @spinnakerbot @cfieber