Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Upgrade Spring Boot to 2.2.13 #812

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented Sep 23, 2021

Refer spinnaker/spinnaker#6537

During verification of spring boot upgrade using spinnaker/kork#895, received below error:

Task :rosco-core:compileTestGroovy
startup failed:
/rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 69: Only @Shared and static fields may be accessed from here @ line 69, column 7.
         SOME_BAKE_REQUEST | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null                 | SOME_AMI_ID       | SOME_BUILD_INFO_URL | SOME_BUILD_NR
         ^

/rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 68: Only @Shared and static fields may be accessed from here @ line 68, column 27.
         null              | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null                 | SOME_AMI_ID       | null                | null
                             ^

/rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 69: Only @Shared and static fields may be accessed from here @ line 69, column 27.
         SOME_BAKE_REQUEST | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null                 | SOME_AMI_ID       | SOME_BUILD_INFO_URL | SOME_BUILD_NR
         ^

This PR fix the error while executing the test cases spring boot upgrade.

Refer spinnaker/spinnaker#6537

During verification of spring boot upgrade using spinnaker/kork#895, received below error:
Task :rosco-core:compileTestGroovy
startup failed:
/rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 69: Only @shared and static fields may be accessed from here @ line 69, column 7.
         SOME_BAKE_REQUEST | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null                 | SOME_AMI_ID       | SOME_BUILD_INFO_URL | SOME_BUILD_NR
         ^

/rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 68: Only @shared and static fields may be accessed from here @ line 68, column 27.
         null              | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null                 | SOME_AMI_ID       | null                | null
                             ^

/rosco/rosco-core/src/test/groovy/com/netflix/spinnaker/rosco/providers/CloudProviderBakeHandlerSpec.groovy: 69: Only @shared and static fields may be accessed from here @ line 69, column 27.
         SOME_BAKE_REQUEST | SOME_BAKE_RECIPE | SOME_BAKE_RECIPE_NAME | null                 | SOME_AMI_ID       | SOME_BUILD_INFO_URL | SOME_BUILD_NR
         ^

To fix the error, added @shared in TestDefaults.groovy file.
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Sep 27, 2021
@mergify mergify bot merged commit eaa86d0 into spinnaker:master Sep 27, 2021
@mergify mergify bot added the auto merged label Sep 27, 2021
@j-sandy j-sandy deleted the sb-upgrade-2-2-13 branch October 5, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants