Quick Fix for compiling issues with icc and OpenMP #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a workaround for compatibility when using OpenMP and intel compilers
MSallermann
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #489 +/- ##
===========================================
+ Coverage 51.81% 51.83% +0.01%
===========================================
Files 90 90
Lines 9844 9848 +4
===========================================
+ Hits 5101 5105 +4
Misses 4743 4743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a quick workaround to fix compiling issues when using OpenMP and intel compilers. It is pretty much the same that was done in 19a2bdc.
Unit tests seem to run fine on
icc 18.03and also ongcc 6.2.0