forked from Segfault-Inc/Multicorn
-
Notifications
You must be signed in to change notification settings - Fork 3
Implement aggregation and grouping pushdown #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f51ee8d
Implmentation of aggregation/grouping pushdown
gruuya 26e0d3e
Consult Python FDW instance for upper rel pushdown
gruuya 3f969eb
Add parsing of local and remote conditions in the plan phase
gruuya 96744b4
Remove redundant code and fix compiler warnings
gruuya b37a39e
Remove obsolete struct
gruuya 8541184
Enable queries for aggregation/grouping
gruuya a7bbfd5
Fix aggregation queries with DISTINCT clauses
gruuya ab9d3ab
Fix COUNT(*) statements from crashing
gruuya 7b05afb
Fix a couple of PyObject DECREF's and clarify docstrings
gruuya 051165e
Store supported aggregation functions as a PG List object
gruuya 85e6cbc
Add comments stressing deviations from commonly used FDW code
gruuya 8efb2e8
Fix cases where aggregations of integers do not return an integer
gruuya df5e576
Add comment with explanation for type conversion
gruuya 67ffe22
Fix typo in comment
gruuya 757e00c
Bring back comment on qual re-checking
gruuya a651e11
Fix memory leak when converting row value to PyLong
gruuya 55feb66
Refine the comments in deparse.c and multicorn.c where needed
gruuya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs docs on the expected dict output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding docs for it in the next commit.