Sqlalchemy FDW optional batch size #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildbyte
reviewed
Feb 17, 2022
mildbyte
approved these changes
Feb 17, 2022
Co-authored-by: Artjoms Iskovs <mildbyte@gmail.com>
mildbyte
approved these changes
Feb 21, 2022
python/multicorn/sqlalchemyfdw.py
Outdated
|
|
||
| self.engine = _create_engine(url, self.connect_args) | ||
|
|
||
| self.cast_quals = fdw_options.get("cast_quals", "no") == "yes" |
There was a problem hiding this comment.
Use true/false here to be in line with e.g. postgres_fdw (https://www.postgresql.org/docs/13/postgres-fdw.html#id-1.11.7.42.10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make batch size in the SQLAlchemy FDW nullable.
CU-1wged02