Allow reintrospecting datasets when running sgr cloud load
#617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra argument for `AddExternalRepositoriesRequest` to determine which tables to reintrospect when running `sgr cloud add` (by default, reintrospect tables without a schema).
Add a model for the response from the externals REST endpoint and output/raise introspection errors if they exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option
--introspection-modeforsgr cloud loadwhich allows picking which repositories to reintrospect when adding data to Splitgraph Cloud.By default, we now reintrospect tables that don't have a schema (note this only currently works for the csv plugin, as it supports partial reintrospection). Previous behaviour was that we'd not reintrospect tables with an empty schema and so they'd be introspected at query time. This would mean that any errors introspecting the tables (like wrong external settings) would show up at query time instead of when the user adds the repository. We'd also do extra work reintrospecting on every query.