Skip to content

[Cache expiration] E2E tests and Type Definitions #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 31, 2025
Merged

[Cache expiration] E2E tests and Type Definitions #135

merged 9 commits into from
Mar 31, 2025

Conversation

EmilianoSanchez
Copy link
Contributor

JS Browser SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review January 17, 2025 22:08
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner January 17, 2025 22:08
@EmilianoSanchez EmilianoSanchez marked this pull request as draft January 17, 2025 22:08
@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review January 17, 2025 22:37
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition 8.4% 8.39% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition 6.4% 6.38% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@EmilianoSanchez EmilianoSanchez merged commit 5859276 into development Mar 31, 2025
7 of 8 checks passed
@EmilianoSanchez EmilianoSanchez deleted the cache_expiration branch March 31, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZamoraEmmanuel ZamoraEmmanuel ZamoraEmmanuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @ZamoraEmmanuel