Large Segments: update mySegments storages to handle change number and updates from notifications #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
changed the title
Base automatically changed from
SDKS-8407_unify_notifications
to
SDKS-8407_baseline
September 3, 2024 18:32
EmilianoSanchez
deleted the
SDKS-8407_mySegments_storages_updates_part2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript commons library
What did you accomplish?
resetSegmentsmethod to handle both resets with/membershipresponses and updates with streaming notification payloads (e.g., segment removals and key lists).How do we test the changes introduced in this PR?
Extra Notes