Skip to content

fix: remove enterprise cloud ToS code for login page #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: remove enterprise cloud ToS code for login page #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions pytest_splunk_addon_ui_smartx/components/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#

import time

from selenium.common.exceptions import TimeoutException
from selenium.webdriver.common.by import By

Expand All @@ -41,8 +38,6 @@ def __init__(self, browser, container=Selector(select="form.loginForm")):
"username": Selector(by=By.ID, select="username"),
"password": Selector(by=By.ID, select="password"),
"homepage": Selector(select='a[data-action="home"]'),
"accept_checkbox": Selector(by=By.ID, select="accept"),
"accept_button": Selector(select=" .accept-tos-button.btn.btn-primary"),
}

def login(self, username, password):
Expand All @@ -51,19 +46,7 @@ def login(self, username, password):
:param username: Str the username for the splunk instance we want to access
:param password: Str the password for the splunk instance we want to access
"""

global ENTERPRISE_CLOUD_ToS

self.username.send_keys(username)
self.password.send_keys(password)
self.password.send_keys("\ue007")
try:
if ENTERPRISE_CLOUD_ToS:
ENTERPRISE_CLOUD_ToS = False
self.wait_to_be_clickable("accept_checkbox")
self.accept_checkbox.click()
self.wait_for("accept_button")
self.accept_button.click()
except TimeoutException:
pass
self.wait_for("homepage", "Could not log in to the Splunk instance.")