fix: ADDON-66912 SingleSelect is_editable fix and add SingleSelect allow_new_values #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low_new_values (#412) - Fix SingleSelect is_editable() checking if field can be modified on edit - Add SingleSelect allow_new_values() checking if field accepts custom values - add corresponding UI tests - override BaseComponents wait_to_be_stale() in Dropdown and add to flaky tests to resolve a Stale Element Error Reference: https://splunk.atlassian.net/browse/ADDON-66912?atlOrigin=eyJpIjoiYzViOTFiMDhhMjY5NGVhNTg3YjViOWFkNGM5MjE0NDgiLCJwIjoiamlyYS1zbGFjay1pbnQifQ https://splunk.atlassian.net/browse/ADDON-65416?atlOrigin=eyJpIjoiOTdjYTk4MWExMzMzNDI3MTgzYjJmMjkxYWRmNzdkZDMiLCJwIjoiamlyYS1zbGFjay1pbnQifQ
kdoroszko-splunk
approved these changes
Dec 1, 2023
|
🎉 This PR is included in version 2.5.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as in #412.
Reference:
Released as beta and tested: