Fix checking during mode:changes #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would not be tested if it contained the string "dist" in the name. This was due to how we checked whether or not modified content was in the appropriate content folders like detections, macros, and lookups or whether it was in a folder like dist/ or app_template. The way this checking is done is now improved so we examine the paths using is_relative_to instead of looking for a substring in the path.
patel-bhavin
approved these changes
Jul 10, 2024
|
Full path checking, FTW! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where a detection that changed
would not be tested if it contained the
string "dist" in the name. This was due
to how we checked whether or not
modified content was in the appropriate
content folders like detections, macros,
and lookups or whether it was in a folder
like dist/ or app_template. The way this
checking is done is now improved so we
examine the paths using is_relative_to
instead of looking for a substring in the
path.