updating error handling on selected testing #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyth0n1c
previously approved these changes
Jul 26, 2024
There was a problem hiding this comment.
This is due to the newly implemented eq method in v4.2.0. That was added along with lt and hash to make sorting and set operations easier for all SecurityContentObjects. eq and lt not can ONLY occur between SecurityContentObjects - it should not work (and should raise an exception) for tests between any other objects.
This INCLUDEs None. In addition since x is None is more Pythonic than x == None, we probably want to maintain this behavior.
pyth0n1c
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing a bug on selected changes for unit -testing when selected!