Remove SSA specific code #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change typing of the detection_abstract search field from dict | str to str. dict | str WAS in place to support sigma searches, but that functionality has since been removed.
are no longer required
Resolve merge conflicts
pyth0n1c
previously approved these changes
Aug 21, 2024
There was a problem hiding this comment.
During my review, I encountered some issues where build_ssa and referneces to it were not removed. Those have been fixed.
Similarly, detection.search was still typed as a dict|str (to support sigma content) and all references to that have been converted to JUST a str.
Looks good and I approve!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code related to ssa detections