Abstract Commonly Used Annotated Type Definitions #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his avoid redefining them in multiple places
|
@pyth0n1c none of the CI tests run with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add annotated type definitions for commonly used Annotated Strings. This avoid redefining them in multiple places.
It also ensures that if we need to make an update, it only happens in one place.
The MITRE CVE Type annotations were wrong in a number of places - because they were not defined correctly, (notable, they were missing the
Field()around the pattern) they were not working. For example:id: Annotated[str, r"^CVE-[1|2]\d{3}-\d+$"]is WRONG and should beid: Annotated[str, Field(pattern=r"^CVE-[1|2]\d{3}-\d+$")]if used directly