Ryanplasma add explanation #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the jinja2 template. escapeNewlines() was ONLY being applied to the detection.description before, but it MUST be applied to the explanation as well. This bug was confirmed by generating some conf files with description and/or explanations, with spaces, defined. Now, whichever value is used to populate that field is properly escaped.
pyth0n1c
commented
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been copied from the following external pr contributed by @ryanplasma:
#233
This change includes some more documentation on the Explanation field.
Additionally, it fixes a bug where the explanation field is defined, newlines in it are
not properly escaped.
Since I am unable to edit the original PR, I am closing that out and linking to this one
with changes.