Skip to content

Allow absent tests for experimental detections #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Allow absent tests for experimental detections #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74874e2
Allow absent tests for experimental detections
linuxdaemon Aug 9, 2023
59888f1
Update detection_abstract.py
pyth0n1c Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contentctl/objects/abstract_security_content_objects/detection_abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,9 @@ def encode_error(cls, v, values, field):
# # Found everything
# return v

@validator("tests")
@validator("tests", always=True)
def tests_validate(cls, v, values):
if values.get("status","") != DetectionStatus.production and not v:
if values.get("status","") == DetectionStatus.production.value and not v:
raise ValueError(
"tests value is needed for production detection: " + values["name"]
)
Expand All @@ -153,7 +153,7 @@ def datamodel_valid(cls, v, values):
return v

def all_tests_successful(self) -> bool:
if len(self.tests) == 0:
if len(self.tests) == 0 and self.status is DetectionStatus.production.value:
return False
for test in self.tests:
if test.result is None or test.result.success == False:
Expand Down