Skip to content

Data source output fields validation #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 9, 2025
Merged

Data source output fields validation #377

merged 5 commits into from
Mar 9, 2025

Conversation

P4T12ICK
Copy link
Contributor

@P4T12ICK P4T12ICK commented Mar 5, 2025

new validation:

  • Checks if all output_fields defined in a data_source object is present in the detection

@P4T12ICK P4T12ICK requested a review from pyth0n1c March 5, 2025 10:10
pyth0n1c
pyth0n1c reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments on the changes

Patrick Bareiss and others added 2 commits March 6, 2025 09:30
pyth0n1c
pyth0n1c approved these changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes with the author, checked code and tested locally.
Looks good to me, approved!

@pyth0n1c pyth0n1c merged commit ac074dd into main Mar 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyth0n1c pyth0n1c pyth0n1c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P4T12ICK @pyth0n1c