release notes - add windows path support #391
Conversation
There was a problem hiding this comment.
I think a better way to do this is probably a slightly more complex change, but probably more pythonic? We should consider converting the directories from strings to actual pathlib.Path objects and then using file_path.is_relative_to(directory_path)
While this requires more changes in the file, I think this is a lot cleaner and "more correct" - any thoughts on this change instead?
|
@0xC0FFEEEE I've made the alternative change here which updates the typing on the directory field - can you give a look at that one as well and tell me your thoughts in comparison to this one? Either way, we will get your PR or the PR below merged in the next day or two. Thanks as always for your contributions and feedback :) |
|
I am going to close out this PR and merge the following PR, linked above, which has a slightly different solution implemented by converting a list of directory names as strings to more proper Python pathlib.Path objects. |
2 participants
Simple change that converts trailing slashes of content directories to blackslashes on Windows systems.