Fix runtime csv testing error #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mode:changes, we tried to get the filename of a runtimeCSV. runtimeCSV does not have a filename, this raises an exception. which caused mode:changes testing to fail. As a solution, we just except this type from testing during changes since no content is supposed to use it directly anyway.
patel-bhavin
approved these changes
Apr 18, 2025
|
creates the plan correctly! contentctl test --plan-only mode:changes --mode.target-branch develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing with
contentctl test mode:changes ...would fail due to the presence of the new RuntimeCSV type.The code was checking for the filename of a RuntimeCSV Lookup, however this does not exist and is set to None, since it exists only at runtime.
Now, we just exclude instances of RuntimeCSV from the mode:changes checking to see what needs to be tested.