Skip to content

Update new content generator with new formats #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2023
Merged

Update new content generator with new formats #44

merged 1 commit into from
Nov 28, 2023

Conversation

linuxdaemon
Copy link
Contributor

@linuxdaemon linuxdaemon commented Aug 14, 2023 •
edited
Loading

The schema for the yaml files changed, this updates the new_content_generator to match, producing mostly valid detections for users.

@pyth0n1c pyth0n1c changed the base branch from main to customer_prs_1 November 28, 2023 01:40
pyth0n1c
pyth0n1c approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working! Thank you for this PR. content created in this way still does not pass validate immediately, but this is by design. Fields like "risk_score" must still be entered manually.

@pyth0n1c pyth0n1c merged commit 6d9ffef into splunk:customer_prs_1 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyth0n1c pyth0n1c pyth0n1c approved these changes

Assignees

No one assigned

Labels

external

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linuxdaemon @pyth0n1c @patel-bhavin