Bring together the latest improvements #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of having it be a dictionary. This allows for better validation and is more Pythonic. Also, validate that only valid observables are used in the message field of a detection and that every observable declared is used in the message field.
search as well for the notables that we have called out. A more thorough check will also be done after the search runs in contentctl test, but this static check will likely catch most simple issues.
when fields are missing after running a search with real data on a splunk instance. This helps determine to and even higher degree if notables were declared correctly and gives a high degree of certainty that they will be generated correctly in ES.
missing a notable field in the underlying search
by removing un-needed libraries
and message fields - these should be allowed to be independent. Still require that all fields called out in the message or in the observable are present in the search. This commit adds in the static checks.
for macros and lookups. Now, if we do not find a macro or a lookup instead of just ignoring it we will throw an error.
detections which have been affected by updated macros and/or lookups, to include lookup CSV and/or YML files.
by removing quotes.
a number of areas centered around the contentctl_test.yml configuration file and underlying object. This will support better for testing against multiple targets.
Don't override default test options unless CLI arguments are actually passed.
…l support for passing the address and credentials of servers on the command line.
or environment variable environments!
WORKS, but only produces a warning message. It is presently disabled due to a large amount of nonconformant content.
process when an appinspect throws any kind of errors/warnings/failures/ manual checks. All of these can prevent automatic approval in Splunkbase or deployment of an app.
mode all does not require a git repo for testing. Make sure that when ES is installed, the proper roles are created.
version_control_config for testing using --mode selected.
This helps track progress in CI/CD testing.
and deprecated detections
for non default branch works.
pyth0n1c
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring together the latest improvements into one branch
#57
#34