Use github_webhooks macro. #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftrightleft
approved these changes
Mar 31, 2022
|
Hey @derkkila - Bump on this PR. Mind getting some 👀 on it? |
|
@larrys The Workflow Logs portion doesn't use a macro yet as that particular panel is available in a sort of beta mode since the Workflow Log Exporter is also currently in Beta. If you are interested, please message me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates places using github webhooks index needs to use the macro.
There is also https://github.com/splunk/github_app_for_splunk/blob/main/github_app_for_splunk/default/data/ui/views/workflow_details.xml#L197, but I'm not sure what macro to use for this.