Skip to content

fix: fix incorrect logging #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2023
Merged

fix: fix incorrect logging #405

merged 4 commits into from
Aug 31, 2023

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Aug 31, 2023 •
edited
Loading

kafka-connect-splunk/src/main/java/com/splunk/kafka/connect/SplunkSinkTask.java

Line 316 in 95adc9c

log.error(String.format("failed to send batch %s", batch.getUUID()), ex);
used incorrect method to log the exception, use the correct one as per doc.

@VihasMakwana VihasMakwana temporarily deployed to workflow-approval August 31, 2023 11:36 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

Unit Test Results

165 tests   165 ✔️  38s ⏱️
  23 suites      0 💤
  23 files        0 ❌

Results for commit 0d90fb6.

♻️ This comment has been updated with latest results.

@VihasMakwana VihasMakwana temporarily deployed to workflow-approval August 31, 2023 11:45 — with GitHub Actions Inactive
@VihasMakwana VihasMakwana temporarily deployed to workflow-approval August 31, 2023 11:48 — with GitHub Actions Inactive
@VihasMakwana VihasMakwana merged commit 2372eb4 into develop Aug 31, 2023
@VihasMakwana VihasMakwana deleted the fix-logging branch August 31, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VihasMakwana