Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logging macros by inline functions #8

Closed
hasselmm opened this issue Jan 18, 2013 · 2 comments
Closed

Replace logging macros by inline functions #8

hasselmm opened this issue Jan 18, 2013 · 2 comments

Comments

@hasselmm
Copy link
Contributor

Shouldn't the logging macros get replaced by inline functions? The currently needed all-upper-case macros look rather disruptive in otherwise all-lower-case code. IMHO. Can prepare a pull request if you agree that this deserves a look.

@mikedickey
Copy link
Contributor

The PION_LOG_* macros are just redefinitions of other macros used by , and the standard used by Boost libraries is that macros are all uppercase. It sounds like what you have in mind is some new class that uses inlines to wrap the macros. I agree this might make the code look cleaner, but it would also be a rather disruptive change -- maybe not so much in substance, but the diffs would be pretty big. I'd prefer not to try doing this right now.

At some point down the road I would like to try merging in support for . I know there were some proposals for that a few years ago but not sure what became of them. That might be a better time to try refactoring the logging code.

@hasselmm
Copy link
Contributor Author

Ok. In the end I also could have that classes at my side. Closing this issue.

mikedickey pushed a commit that referenced this issue Jun 2, 2014
# By Mignon Belongie
# Via Mignon Belongie
* commit '02b2cb0c8358f401e54f4c7e8bcae3ed9079629f':
  PION-1320: Debug configurations not working for MSVC Added "del $(LastBuildState)" to PostBuildEvent commands, so that PionNetServices and TestPlugins will always be out of date, and thus always copy the DLLs. Cleaned up TestPlugins.vcxproj. 'TestPluigins' -> 'TestPlugins'
  PION-1320: Debug configurations not working for MSVC Updated Debug_DLL_pion.props to remove 'EditAndContinue' setting. Removed obsolete stuff from pion_plugin.props. Cleaned up services/*.vcxproj and updated AllowNothingService. Updated pion.sln to build debug configurations.
  PION-1320: Debug configurations not working for MSVC Added debug configurations for test plugins.
  PION-1320: Debug configurations not working for MSVC Updated debug configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants