feat: migrate from helmut to splunksplwrapper #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: migrate from helmut to splunksplwrapper BREAKING CHANGE: migrate from helmut to splunksplwrapper * ci: some minor chagnes for CI * ci: update agreements workflow
uoboda-splunk
approved these changes
Feb 22, 2023
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow us to reuse "helmut" (splunksplwrapper) functionality without importing PSA directly which should make PSA development easier and faster.
splunksplwrappermay be reused during the modular tests implementation in the future.It is a breaking change for some of the PSA clients because some of them directly import
helmutfrom PSA which will not be possible anymore. Impacted clients would need to installsplunksplwrapperand use the same functionality from this new library.Test PR with one of the add-ons: https://github.com/splunk/splunk-add-on-for-google-workspace/pull/420
BREAKING CHANGE: migrate from helmut to splunksplwrapper