-
Notifications
You must be signed in to change notification settings - Fork 425
Analytics Promotion & Updates #3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates:
|
ljstella
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just updated from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes some experimental rules to production as well as fixes data sources of others:
Promoted Rules
This first list uses the
manual_test
tag, since it requires the execution of a baseline first or some other configsThe following list had its tests / logic updated to account for promotion
The following list contains rules that linked a broken test, hence the test section removed
Deprecated Rules
Windows AD Suspicious GPO Modification
- This was deprecated as the logic was too complicated and no test was provided to accurately know the scope meant for it.Updated Data Sources
Updated / Fixed Logic
Windows MOVEit Transfer Writing ASPX
- Removed the unnecessaryjoin
as we should care about any creation of those type of files not only those created bysystem
.Detect Outbound SMB Traffic
- Fixed an issues in the IP ranges as well as promoted the rule and removed the zeek test that was incorrect.Prohibited Network Traffic Allowed
- Removed the incorrect zeek test link