Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

fix: Remove unused async #188

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Conversation

ryanfaircloth
Copy link
Contributor

@ryanfaircloth ryanfaircloth commented Nov 4, 2021

Each worker is a process or thread of its own having a task on the worker async and wait is unneeded (thread isn't cheap on Linux). To remove the thread and use and continue to re-use the SNMPEngine the task was changed to inherit from a custom class allowing the init method to be used instead.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #188 (73d3215) into develop (86611d3) will increase coverage by 0.10%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
+ Coverage    49.82%   49.92%   +0.10%     
===========================================
  Files           22       22              
  Lines         1417     1410       -7     
===========================================
- Hits           706      704       -2     
+ Misses         711      706       -5     
Impacted Files Coverage Δ
splunk_connect_for_snmp_poller/manager/tasks.py 36.36% <36.36%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86611d3...73d3215. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

Expected release notes (by @rfaircloth-splunk)

features:
suffix parsing (#187) (86611d3)
Container as non root user (89246a9)
added named regex groups and substitute '_' for '.' (#181) (7b37044)
additional data extraction (#177) (4dfa7fd)
don't put empty values and remove trailing index numbers from m… (#173) (e6a2f5b)
linear backoff used while waiting for MIB (#172) (b3c6f0e)
just as for events time for metrics is assigned on SC4SNMP (#165) (1874618)
add check for missing varBinds (#166) (58587cd)
issue a warning when assigned profile is missing (#162) (96b7f8d)
force inventory refresh (#149) (8026248)
add additionalvarbinds to enricher (#126) (98aeaf3)
enrich data with linked tables (#101) (75bdb13)
extract enricher data from config (#97) (123864f)
extract IF-MIB data from an SNMPWALK (#96) (7699591)
support polling the same IP address using multiple profiles (#92) (a6320ca)

fixes:
Remove unused async (6c04bb1)
Add sourcetype to metrics (#185) (23f86d5)
removal of dynamic profiles fix (#182) (ef3851f)
missing profiles check (#174) (b26f5c9)
add check for if walk (#171) (461f245)
warning if profile does not exist (#170) (d8e14dc)
fix issue with onetime walk not running (#168) (490fff6)
fix issue with KeyError metric, double _ids in mongo and problem with new hosts added (#167) (588cb2e)
profiles are now loaded from file every time (#164) (823ff11)
new execution of enricher (#163) (b646e19)
onetime walk retry (#158) (d69a9c7)
removal of unsafe eval call (#157) (843c26a)
bring back previous changes (#161) (0e87f17)
implement new way for enricher to work (8e24841)
onetime walk with enricher (#154) (11a42ca)
matching on both dysDescr and sysObjectId (#156) (15158e8)
default event formatting (#155) (ed96f44)
fetch frequency (#152) (4602304)
allow * in profile (#151) (880dbce)
changed order of validation (#147) (8dd65e4)
add some restrictions for getting profiles from mib server (#145) (3c690a5)
add missing "break" (#144) (9b728d6)
error with no snmp received before timeout (#143) (b50480f)
'get_snmp_data() missing 1 required positional argument: 'additional_metric_fields'' and change error logger to debug (494ecbb)
change github.repository_owner to github.actor (#129) (89a3fb5)
add toJson() method to onetime_task (#127) (04b16f7)
update splunk indexes with meta_index (#116) (6d3f1bc)
changed indexes (#114) (9644663)
change way of checking if profile is an OID to use regex (#112) (277a050)
mongo real time data check (#107) (4526b0c)
change the way of creating host name which is an id in the database (#104) (bbf2733)
forced commit for creating new release (f3081c1)

others (will not be included in Semantic-Release notes):
73d3215 lock
c595adb Update tasks.py
1.5.0-develop.39 (8bcbc98)
Connect to Mongo using URI (f890582)
Connect to Mongo using URI (c267135)
7b2c929 Fix/deletion of index (#178)
pre-commit autoupdate (#175) (42cb2c3)
0f0e621 [ADDON-43861] correct sourcetype for walk
92e091e Fix/default freq dynamic (#160)
456f6db [ADDON-43460] retry and fail if mib unavailable
048ba1d [ADDON-43435] don't remove host if other record uses it
861a40e [ADDON-43362] special builder for error message
bf2293d Feature/dynamic profile (#138)
adding pull request template (7314352)
better exception handling for mib request (a41fab9)
1.5.0-develop.9 (51d7678)
5a8a418 added 2 missing variables
0c2faf1 encapsulated hec sending request + test + correct pycov coverage report
803ff1a added sending error messages to hec isntead of ignoring them
remove local actionlint (3cc058e)
8ea42f0 added missing error messages
c23399b fixing logging level
1.5.0-develop.8 (8e7cc3d)
change image path (7167c4c)
edf4fc9 adding frequency to all metric data and profile if it is set in conf
4dd2c28 Feat/async rework (#122)
disable shellcheck SC1090 (734d523)
add actionlint as pre-commit step (52ac6f8)
allow dependabot[bot] and remove custom allow policy (437745f)
pre-commit autoupdate [ci skip] (e0544a4)
7ef1a09 refactor
remove black from dev dependency (1b07dd8)
add pre-commit step and remove lint step (9ef6611)
update severity threshold for snyk to "high" (#113) (7540a5b)
pre-commit autoupdate [ci skip] (6ff7b00)
pre-commit and debug statements [ci skip] (bb5e0ff)
set threshold for jscdp linter (#105) (c01fb4d)
1.5.0-develop.3 (7306e5d)
fix of duplicated code linter problem (c855088)
fix shellcheck (2fa415a)
apply mypy and flake8 (ec32122)
apply pre-commit isort (9c906f9)
exclude json files from copyright check (f3d6b2d)
update README to include pre-commit (cd6a9eb)
apply pre-commit black (c53b8b6)
pre-commit (9a24536)
33acbbf feat: Replace multiple SNMP walks with one SNMP Bulk (#100)
ebe3ebf Feature/redo walk (#95)
d5879c5 Stubs for lint
9cff184 Stubs for lint
adddbea Stubs for lint
5dc1549 Stubs for lint
2c5a5c3 Feat/multiple profiles2 (#93)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@omrozowicz-splunk omrozowicz-splunk merged commit eea339d into develop Nov 5, 2021
@omrozowicz-splunk omrozowicz-splunk deleted the fix-improve-poller-threading branch November 5, 2021 10:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
@ryanfaircloth
Copy link
Contributor Author

🎉 This PR is included in version 1.5.0-develop.42 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants