-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #160 +/- ##
===========================================
+ Coverage 47.36% 47.45% +0.09%
===========================================
Files 22 22
Lines 1233 1239 +6
===========================================
+ Hits 584 588 +4
- Misses 649 651 +2
Continue to review full report at Codecov.
|
result = [] | ||
for profile in profiles: | ||
if "patterns" in profiles[profile]: | ||
match_profile_with_device(device_desc, profile, profiles, result) | ||
if profiles[profile].get("patterns"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe
if profiles[profile] and profiles[profile].get("patterns"):
just to be protected if somehow profiles[profile] will be None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no way profiles[profile] to be None as profile is an iteration variable over profiles. profiles is a dict and profile is a key in this dic.
@@ -36,6 +36,8 @@ | |||
|
|||
logger = logging.getLogger(__name__) | |||
|
|||
DEFAULT_POLLING_FREQUENCY = 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move it to const file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Expected release notes (by @weliasz) features: fixes: others (will not be included in Semantic-Release notes):
|
🎉 This PR is included in version 1.5.0-develop.21 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Default frequency should be applied also to dynamic profiles
Fixes # (issue)
Type of change
How Has This Been Tested?
I removed frequency from profile that is matched and default frequency was assigned and appropriate log message was placed
Checklist