-
Notifications
You must be signed in to change notification settings - Fork 124
Separate CRD for ClusterMaster & change indexerClusterRef to clusterMasterRef #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
…-operator into feature/Cluster_Master_CRD
Hi @gaurav-splunk, |
Hi @romain-bellanger Thanks for the feedback. This is an issue with the yq version I am using. I will update the PR with correct yq version installed on my machine. That should solve the indentation problem. |
…ure/Cluster_Master_CRD
…-operator into feature/Cluster_Master_CRD
This PR targets the following changes -
Created a new CRD of type ClusterMaster. So now, to deploy an indexer cluster you need to create 2 CRs, one with type as ClusterMaster for CM and one for indexer cluster part with type as IndexerCluster.
With the introduction of new CRD for ClusterMaster, we don't need the old way of using replicas:0 to identify that this is for CM.
We have deprecated indexerClusterRef in favor of ClusterMasterRef. This is done to explicitly mention that any other resource which wants to connect to an indexer cluster will have to connect to Cluster Master part of the indexer cluster.
Moved all the SmartStore related logic to ClusterMaster code since SmartStore can only be configured through CM.
Made changes to UT and System tests accordingly.