Skip to content

Conversation

Igor-splunk
Copy link
Collaborator

No description provided.

@Igor-splunk Igor-splunk changed the base branch from main to develop February 24, 2025 12:10
@coveralls
Copy link
Collaborator

coveralls commented Feb 24, 2025

Pull Request Test Coverage Report for Build 13542710151

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 86.585%

Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/afwscheduler.go 1 92.93%
Totals Coverage Status
Change from base Build 13313195382: 0.01%
Covered Lines: 10540
Relevant Lines: 12173

💛 - Coveralls

Copy link
Collaborator

@patrykw-splunk patrykw-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlieberman-splunk
Copy link
Collaborator

Can we add an integration test that uses a splunkbase app with the .tar.gz extension to actually test the download and install of it? Or did you test it manually?

@Igor-splunk
Copy link
Collaborator Author

Can we add an integration test that uses a splunkbase app with the .tar.gz extension to actually test the download and install of it? Or did you test it manually?

Yeah it works tgz and tar.gz are the exact same thing. tgz is just archaic because old dos floppy disks could only have 3 letters for extensions.

@kasiakoziol kasiakoziol self-requested a review February 27, 2025 13:35
@Igor-splunk Igor-splunk merged commit 2e5cd99 into develop Feb 28, 2025
26 checks passed
@Igor-splunk Igor-splunk deleted the CSPL-3426 branch February 28, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants