CSPL-3704 #1474 Secret Management: SOK deletes automatically smartstore secrets created

[kasiakoziol]

Description

This PR fixes a bug where a Smart Store secret created manually gets removed by the operator on Splunk resources removal because owner references are set by the Operator on the Splunk resources creation for given secret while it should not be managed by SOK.

Key Changes

Moving the DeleteOwnerReferencesForS3SecretObjects execution outside of DeleteOwnerReferencesForResources execution and outside of if cr.ObjectMeta.DeletionTimestamp != nil condition. Additionally, a small check needed to be added to the condition to make unit tests running since they rely on a namespaced secret, not a separate Smart Store secret.

Testing and Verification

Tested manually for S1, C3, M4, S1 & LM & MC, C3 & LM & MC and M4 & LM & MC. Automated tests executed as a part of the process.

Related Issues

https://splunk.atlassian.net/browse/CSPL-3704
#1474

PR Checklist

• Code changes adhere to the project's coding standards.
• Relevant unit and integration tests are included.
• Documentation has been updated accordingly.
• All tests pass locally.
• The PR description follows the project's guidelines.

[coveralls]

Pull Request Test Coverage Report for Build 14970521101

Details

• 28 of 28 (100.0%) changed or added relevant lines in 8 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.005%) to 86.618%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/splunk/enterprise/util.go	1	90.58%

Totals
Change from base Build 14797754026:	0.005%
Covered Lines:	10557
Relevant Lines:	12188

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 14975880958

Details

• 28 of 28 (100.0%) changed or added relevant lines in 8 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.01%) to 86.626%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/splunk/enterprise/util.go	1	90.58%

Totals
Change from base Build 14797754026:	0.01%
Covered Lines:	10558
Relevant Lines:	12188

---

💛 - Coveralls

[rlieberman-splunk]

Can you add the link to the GitHub issue this fixes to the description as well?

[patrykw-splunk]

LGTM!